Repository navigation
Build releases without the turbo cache - #1204
Merged
Merged
Conversation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed all eight workflow changes, the shared Depot cache action, and the release/preview caller paths.
- Release builds: Removes remote Turbo cache setup from npm publishing, CLI binary releases, and macOS notarization jobs; existing native-binary caches remain unchanged.
- macOS cache gating: Adds an optional Depot token to the reusable build workflow, forwards it from CI/preview callers, and leaves release callers without remote caching.
- Scheduled tests: Moves deployment and Next.js canary builds to the existing secret-gated Depot cache action.
The CI build/test and Actions analysis checks passed. The changed macOS and publishing paths were reviewed statically, not executed in this review.
gpt-6.1-sol ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published artifacts no longer depend on any build cache, and the remaining
rharkor/caching-for-turbousers move to the secret-gated Depot turbo cache.release.yaml,binary-release.yaml, andnotarize-native-macos.yamldrop the turbo cache. Their GitHub cache rarely hit anyway now thatmainbuilds write to Depot's cache, so the cost is small and releases are infrequent.build-native-macos.yamltakes an optionalDEPOT_TURBO_TOKENsecret. PR callers (test.yaml,binary-preview.yaml) pass it so Swift PRs reuse the varlock libs build across pushes;release.yamldoesn't, so the release build of the macOS app runs from source.nextjs-canaryanddeploy-tests(scheduled/manual, nothing published) use the Depot turbo cache via the shared action.